bug 2573: support --metadata-output-stream command-line override for config. #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/CommandLine.cpp
Outdated
| { | ||
| // Allow overriding config METADATA_OUTPUT_STREAM using | ||
| // command line --metadata-output-stream | ||
| config.METADATA_OUTPUT_STREAM = stream; |
There was a problem hiding this comment.
Should it just blow up if the setting was already in the config file? I kinda hate the notion of "override" that just creates ambiguity.
There was a problem hiding this comment.
Fair, pushed variant that's exclusive.
graydon
force-pushed
the
bug-2573-metadata-output-from-command-line
branch
from
e0dcc2c
to
5990358
Compare
|
r+ 5990358 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a command-line flag
--metadata-output-streamtorunandcatchupwhich allows users to set theMETADATA_OUTPUT_STREAMconfig variable if it's not set in the config file. This helps enable horizon to run captive core while still using a user-provided config file (with user-provided quorum and so on).