Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make print-xdr display account IDs properly #2546

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Make print-xdr display account IDs properly #2546

merged 1 commit into from
Jun 6, 2020

Conversation

hidenori-shinohara
Copy link
Contributor

@hidenori-shinohara hidenori-shinohara commented May 24, 2020 •
edited
Loading

Description

Resolves issue #2528 by implementing xdr_printer for MuxedAccount

This change is almost the same as PR #2536, but I closed the PR because I accidentally created the PR from my master branch, which created some problems.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@hidenori-shinohara hidenori-shinohara changed the title Make print-xdr display account IDs properly #2536 Make print-xdr display account IDs properly May 24, 2020
jonjove
jonjove reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@jonjove jonjove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick, then looks good to me.

src/main/dumpxdr.cpp Outdated Show resolved Hide resolved
@MonsieurNicolas
Copy link
Contributor

This looks good to me.

Only change I would make is use fmt::format instead of std::stringstream as it's lot faster and easier to read.

@hidenori-shinohara
Copy link
Contributor Author

Just changed from std::stringstream to fmt::format!

@MonsieurNicolas
Copy link
Contributor

r+ 9128f7d

@latobarita latobarita merged commit 9cecd4e into stellar:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjove jonjove jonjove left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidenori-shinohara @MonsieurNicolas @latobarita @jonjove