Cap 0027: first class multiplexed accounts #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
changed the title
jonjove
reviewed
Apr 13, 2020
| @@ -47,7 +47,7 @@ PathPaymentStrictReceiveOpFrame::doApply(AbstractLedgerTxn& ltx) | |||
| return false; | |||
| } | |||
| innerResult().success().last = SimplePaymentResult( | |||
| getDestID(), getDestAsset(), mPathPayment.destAmount); | |||
| getDestMuxedAccount(), getDestAsset(), mPathPayment.destAmount); | |||
There was a problem hiding this comment.
This change isn't mentioned in the proposal. Is this change actually desired?
There was a problem hiding this comment.
yeah I saw this too. I don't think we can actually do this either as SDKs are probably using the return the RAW result (like exchanges checking if a transaction is for them).
This is not a conversation for the PR but against the CAP, so let's discuss elsewhere.
There was a problem hiding this comment.
Oh it was actually mentioned. I missed it as well (last bullet point).
The following fields, which were previously an AccountID or AccountID*, are now a MuxedAccount or MuxedAccount* (respectively):
PaymentOp::destination
PathPaymentStrictReceiveOp::destination
PathPaymentStrictSendOp::destination
Operation::sourceAccount
Operation::destination (for ACCOUNT_MERGE)
Transaction::sourceAccount
SimplePaymentResult::destination
| innerResult().success().last = | ||
| SimplePaymentResult(getDestID(), getDestAsset(), maxAmountSend); | ||
| innerResult().success().last = SimplePaymentResult( | ||
| getDestMuxedAccount(), getDestAsset(), maxAmountSend); |
There was a problem hiding this comment.
Same comment as for PathPaymentStrictReceipeOpFrame.
MonsieurNicolas
force-pushed
the
cap-0027-MuxedAccounts
branch
2 times, most recently
from
03eb108
to
7253b0b
Compare
MonsieurNicolas
force-pushed
the
cap-0027-MuxedAccounts
branch
from
7253b0b
to
ef71e8c
Compare
|
r+ ef71e8c |
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements CAP-0027 : First-class multiplexed accounts
This PR addresses feedback from #2497
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)