Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing archive name in command-line catchup #2319

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Allow passing archive name in command-line catchup #2319

merged 1 commit into from
Nov 2, 2019

Conversation

marta-lokhova
Copy link
Contributor

Resolves #2311

@MonsieurNicolas
Copy link
Contributor

Cool. Curious to understand the trade off you made @marta-lokhova :
In this proposal, you first classed the ability to "stick" to a given archive for catchup.
A simpler solution would be to filter out archives from the configuration file that would not require making changes to any of the logic (leaving room for different filtering where the filtered set is not a single archive)

@MonsieurNicolas
Copy link
Contributor

r+ 012168f

latobarita added a commit that referenced this pull request Nov 2, 2019
@latobarita
Merge pull request #2319 from marta-lokhova/archive_arg_catchup
d9173b0 
Allow passing archive name in command-line catchup

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit 012168f into stellar:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command line catchup should allow passing in an archive
3 participants
@marta-lokhova @MonsieurNicolas @latobarita