Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing information from TransactionMeta in older protocol versions #2315

Merged
merged 4 commits into from
Nov 2, 2019

Conversation

jonjove
Copy link
Contributor

@jonjove jonjove commented Oct 15, 2019

Resolves #2217

This PR introduces a new version (version 2) of TransactionMeta and allows stellar-core to be configured to generate either version 1 or version 2.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@MonsieurNicolas
Copy link
Contributor

r+ b299b3a

latobarita added a commit that referenced this pull request Nov 1, 2019
Fix missing information from TransactionMeta in older protocol versions

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit b299b3a into stellar:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction meta is missing one time signer changes in older versions of the protocol
3 participants