Remove publish snapshot race condition #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this work is scheduled for 11.1 (in order to take advantage of the updated Work), any reason to do this fix now? |
|
I had this fix for a while actually. This particular race condition bug seems unrelated to the new Work interface (new Work doesn't touch anything related to when/how publish is triggered), hence a different PR. |
|
r+ 628e8a7 |
|
(btw I changed your comment to not say "resolves X" to avoid auto-closing the issue ; I don't think github is smart enough to see that there was a "partially" in front) @marta-lokhova |
good call, thanks! |
latobarita
added a commit
that referenced
this pull request
Jan 4, 2019
Remove publish snapshot race condition Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially deals with #1750 by always publishing snapshots from the publish queue.