New work interface #1801

marta-lokhova · 2018-09-26T18:42:52Z

{should NOT be merged}

This is an initial prototype of the Work interface described here. It includes implementations of the new interface (BasicWork & Work), the scheduler (WorkScheduler), as well as a few examples on how existing works can utilize it (including RunCommandWork, DownloadBucketsWork etc).

For the refactored works, it's better to look at the whole files (as opposed to diffs). I left some of the tests from before I made the breaking changes (like actually renamed the classes) in case it is useful.

…emoteFile works

src/work/BasicWork.cpp

src/work/BasicWork.h

src/historywork/RunCommandWork.h

src/work/BasicWork.cpp

marta-lokhova · 2018-10-01T22:37:31Z

Thanks for reviewing! I've made some updates, mostly addressing design-related comments. Like I mentioned before, I'm not focusing on particular optimizations/other nits for this iteration, as it will be addressed once we agree on the design.

src/historywork/VerifyBucketWork.cpp

src/work/Work.cpp

src/historywork/RunCommandWork.h

src/work/BasicWork.cpp

src/work/Work.h

src/work/BasicWork.cpp

src/work/WorkScheduler.cpp

src/work/Work.h

src/catchup/DownloadBucketsWork.cpp

src/work/BasicWork.h

src/work/BasicWork.cpp

src/work/Work.h

…ence for convenience

… WorkSequence

MonsieurNicolas

A few questions just on BasicWork for now

src/work/BasicWork.h

src/work/BasicWork.cpp

marta-lokhova · 2018-11-13T01:51:11Z

This prototype has served its purpose - closing it in favor of #1819

marta-lokhova added 8 commits September 26, 2018 11:02

Define BasicWork interface

796e7d5

Implemented Work class and WorkScheduler class

83a9590

Add WorkScheduler to Application

b9c9475

Updated implementation of RunCommandWork

8db634f

Example implementations of GetRemoteFile, GunzipFile and GetAndUnzipR…

4e1cbbe

…emoteFile works

Example implementation of GetHistoryArchiveStateWork

cb36fe7

Example implementation of DownloadBucketWork and VerifyBucketWork

b30c750

Added a few tests

162a67e

jonjove reviewed Sep 27, 2018

View reviewed changes

Updated Work-related classes based on comments

73fdbd5

marta-lokhova commented Oct 1, 2018

View reviewed changes

src/historywork/VerifyBucketWork.cpp Outdated Show resolved Hide resolved

jonjove reviewed Oct 2, 2018

View reviewed changes

Verious updates

445a844

marta-lokhova commented Oct 9, 2018

View reviewed changes

src/work/Work.h Show resolved Hide resolved

marta-lokhova commented Oct 9, 2018

View reviewed changes

src/catchup/DownloadBucketsWork.cpp Show resolved Hide resolved

marta-lokhova force-pushed the new_work_interface branch from 7e8ef67 to 946fbde Compare October 9, 2018 18:51