Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overlay survey script to support new time sliced survey #4302

Closed
bboston7 opened this issue May 2, 2024 · 4 comments · Fixed by #4342
Closed

Update overlay survey script to support new time sliced survey #4302

bboston7 opened this issue May 2, 2024 · 4 comments · Fixed by #4342
Assignees

Comments

@bboston7
Copy link
Contributor

bboston7 commented May 2, 2024

#4275 adds a new time sliced survey mechanism with new HTTP endpoints for running a survey. We should update the python script to use the new endpoints.

@marta-lokhova
Copy link
Contributor

Just double checking here: there is no dependency between this issue and #4275, because we'd still support old-style survey, so the script can be updated whenever we're ready to run/test survey V2, right?

@bboston7
Copy link
Contributor Author

bboston7 commented May 3, 2024

Yes, that's right. #4275 leaves the old survey interface intact so there's no need to immediately update the script.

@marta-lokhova
Copy link
Contributor

Quick note here: I bumped priority of this issue to P0, since we'd need the new script to test survey v2 (ideally, we can do this during RC stage of our v21.1.0 release process to catch any issues before bumping to stable)

@bboston7
Copy link
Contributor Author

bboston7 commented May 15, 2024

Good point. At this point I don't think the HTTP interfaces in #4275 will change significantly (if at all), so I'll start working on updating the script.

ThomasBrady pushed a commit to ThomasBrady/stellar-core that referenced this issue Jun 20, 2024
Resolves stellar#4302

This change updates the network overlay survey script to support the new
V2 survey API.

To test this, I also updated the simulator to simulate the new API, then
I checked that the resulting graph from simulating an old pubnet
survey is structurally isomorphic to the input graph. I also checked
that the new fields are present in the output graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bboston7 @marta-lokhova and others