Skip to content

Commit

Permalink
Only test SCP driver with the current and prev protocol. (#4400)
Browse files Browse the repository at this point in the history
# Description

Only test SCP driver with the current and previous  protocols.

We no longer need to support the generalized tx set migration scenarios,
and it makes sense to only cover the two protocols that any given Core
build might run.

# Checklist
- [ ] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [ ] Compiles
- [ ] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
  • Loading branch information
marta-lokhova authored Jul 26, 2024
2 parents f949c77 + 579ccca commit cab8e20
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/herder/test/HerderTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2618,14 +2618,9 @@ testSCPDriver(uint32 protocolVersion, uint32_t maxTxSetSize, size_t expectedOps)

TEST_CASE("SCP Driver", "[herder][acceptance]")
{
SECTION("before generalized tx set protocol")
SECTION("previous protocol")
{
testSCPDriver(static_cast<uint32>(SOROBAN_PROTOCOL_VERSION) - 1, 1000,
15);
}
SECTION("generalized tx set protocol")
{
testSCPDriver(static_cast<uint32>(SOROBAN_PROTOCOL_VERSION), 1000, 15);
testSCPDriver(Config::CURRENT_LEDGER_PROTOCOL_VERSION - 1, 1000, 15);
}
SECTION("protocol current")
{
Expand Down

0 comments on commit cab8e20

Please sign in to comment.