Skip to content

Commit

Permalink
Ban ENABLE_SOROBAN_DIAGNOSTIC_EVENTS when isNetworkedValidator
Browse files Browse the repository at this point in the history
  • Loading branch information
graydon committed Sep 13, 2023
1 parent dbcd1d5 commit a19fd53
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/main/ApplicationImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,13 @@ ApplicationImpl::validateAndLogConfig()
auto const isNetworkedValidator =
mConfig.NODE_IS_VALIDATOR && !mConfig.RUN_STANDALONE;

if (mConfig.ENABLE_SOROBAN_DIAGNOSTIC_EVENTS && isNetworkedValidator)
{
throw std::invalid_argument("ENABLE_SOROBAN_DIAGNOSTIC_EVENTS is set, "
"NODE_IS_VALIDATOR is set, and "
"RUN_STANDALONE is not set");
}

if (mConfig.METADATA_OUTPUT_STREAM != "" && isNetworkedValidator)
{
throw std::invalid_argument(
Expand Down

5 comments on commit a19fd53

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from sisuresh
at graydon@a19fd53

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging graydon/stellar-core/ban-soroban-diagnostics-when-networked-validator = a19fd53 into auto

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graydon/stellar-core/ban-soroban-diagnostics-when-networked-validator = a19fd53 merged ok, testing candidate = 03fa3a7

@latobarita
Copy link
Contributor

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 03fa3a7

Please sign in to comment.