Update Core to protocol 22. (#4464)

# Description

Update Core to protocol 22 and ungate the tests that rely on the new
protocol.

# Checklist
- [ ] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [ ] Compiles
- [ ] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)

Builds/VisualStudio/stellar-core.vcxproj

@@ -596,6 +596,7 @@ exit /b 0
     <ClCompile Include="..\..\src\ledger\LedgerHeaderUtils.cpp" />
     <ClCompile Include="..\..\src\ledger\LedgerManagerImpl.cpp" />
     <ClCompile Include="..\..\src\ledger\LedgerRange.cpp" />
+    <ClCompile Include="..\..\src\ledger\LedgerStateSnapshot.cpp" />
     <ClCompile Include="..\..\src\ledger\LedgerTxn.cpp" />
     <ClCompile Include="..\..\src\ledger\LedgerTxnAccountSQL.cpp" />
     <ClCompile Include="..\..\src\ledger\LedgerTxnClaimableBalanceSQL.cpp" />
@@ -1041,6 +1042,7 @@ exit /b 0
     <ClInclude Include="..\..\src\ledger\LedgerManager.h" />
     <ClInclude Include="..\..\src\ledger\LedgerManagerImpl.h" />
     <ClInclude Include="..\..\src\ledger\LedgerRange.h" />
+    <ClInclude Include="..\..\src\ledger\LedgerStateSnapshot.h" />
     <ClInclude Include="..\..\src\ledger\LedgerTxn.h" />
     <ClInclude Include="..\..\src\ledger\LedgerTxnEntry.h" />
     <ClInclude Include="..\..\src\ledger\LedgerTxnHeader.h" />

Builds/VisualStudio/stellar-core.vcxproj.filters

@@ -1377,6 +1377,9 @@
     <ClCompile Include="..\..\src\main\QueryServer.cpp">
       <Filter>main</Filter>
     </ClCompile>
+    <ClCompile Include="..\..\src\ledger\LedgerStateSnapshot.cpp">
+      <Filter>ledger</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="..\..\lib\util\cpptoml.h">
@@ -2402,6 +2405,9 @@
     <ClInclude Include="..\..\src\main\QueryServer.h">
       <Filter>main</Filter>
     </ClInclude>
+    <ClInclude Include="..\..\src\ledger\LedgerStateSnapshot.h">
+      <Filter>ledger</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <None Include="..\..\AUTHORS" />

src/herder/test/HerderTests.cpp

@@ -5556,7 +5556,7 @@ TEST_CASE("SCP message capture from previous ledger", "[herder]")
     simulation->addConnection(validatorCKey.getPublicKey(),
                               validatorBKey.getPublicKey());
     simulation->crankUntil(
-        [&]() { return C->getLedgerManager().getLastClosedLedgerNum() == 3; },
+        [&]() { return C->getLedgerManager().getLastClosedLedgerNum() >= 3; },
         4 * Herder::EXP_LEDGER_TIMESPAN_SECONDS, false);
 
     // C should have 3 EXTERNALIZEs in its scphistory table for ledger 2. This

src/main/Config.cpp

@@ -33,7 +33,7 @@
 
 namespace stellar
 {
-const uint32 Config::CURRENT_LEDGER_PROTOCOL_VERSION = 21
+const uint32 Config::CURRENT_LEDGER_PROTOCOL_VERSION = 22
 #ifdef ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
                                                        + 1
 #endif

src/transactions/test/InvokeHostFunctionTests.cpp

@@ -4331,7 +4331,6 @@ TEST_CASE("Vm instantiation tightening", "[tx][soroban]")
     }
 }
 
-#ifdef ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
 TEST_CASE("contract constructor support", "[tx][soroban]")
 {
     Config cfg = getTestConfig();
@@ -4432,4 +4431,3 @@ TEST_CASE("contract constructor support", "[tx][soroban]")
         REQUIRE(invocation.getReturnValue().u32() == 303);
     }
 }
-#endif

src/transactions/test/TxEnvelopeTests.cpp

@@ -2493,7 +2493,6 @@ TEST_CASE("soroban txs not allowed before protocol upgrade",
     REQUIRE(tx->getResult().result.code() == txMALFORMED);
 }
 
-#ifdef ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
 TEST_CASE("XDR protocol compatibility validation", "[tx][envelope]")
 {
     auto validateTx = [](ProtocolVersion protocolVersion) {
@@ -2525,7 +2524,6 @@ TEST_CASE("XDR protocol compatibility validation", "[tx][envelope]")
         REQUIRE(res->isSuccess());
     }
 }
-#endif
 
 TEST_CASE_VERSIONS("Soroban extension for non-Soroban tx",
                    "[tx][envelope][soroban]")