Merge pull request #4150 from MonsieurNicolas/addMetaMetric

Add metric to track metra production Reviewed-by: marta-lokhova
stellar · Jan 20, 2024 · 92ddf1e · 92ddf1e
2 parents 3138474 + 49747dc
commit 92ddf1e
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/docs/metrics.md b/docs/metrics.md
@@ -61,6 +61,7 @@ ledger.catchup.duration                   | timer     | time between entering LM
 ledger.invariant.failure                  | counter   | number of times invariants failed
 ledger.ledger.close                       | timer     | time to close a ledger (excluding consensus)
 ledger.memory.queued-ledgers              | counter   | number of ledgers queued in memory for replay
+ledger.metastream.bytes                   | meter     | number of bytes written per ledger into meta-stream
 ledger.metastream.write                   | timer     | time spent writing data into meta-stream
 ledger.operation.apply                    | timer     | time applying an operation
 ledger.operation.count                    | histogram | number of operations per ledger

diff --git a/src/ledger/LedgerManagerImpl.cpp b/src/ledger/LedgerManagerImpl.cpp
@@ -145,6 +145,8 @@ LedgerManagerImpl::LedgerManagerImpl(Application& app)
           app.getMetrics().NewCounter({"ledger", "apply", "success"}))
     , mTransactionApplyFailed(
           app.getMetrics().NewCounter({"ledger", "apply", "failure"}))
+    , mMetaStreamBytes(
+          app.getMetrics().NewMeter({"ledger", "metastream", "bytes"}, "byte"))
     , mMetaStreamWriteTime(
           app.getMetrics().NewTimer({"ledger", "metastream", "write"}))
     , mLastClose(mApp.getClock().now())
@@ -682,8 +684,10 @@ LedgerManagerImpl::emitNextMeta()
     auto streamWrite = mMetaStreamWriteTime.TimeScope();
     if (mMetaStream)
     {
-        mMetaStream->writeOne(mNextMetaToEmit->getXDR());
+        size_t written = 0;
+        mMetaStream->writeOne(mNextMetaToEmit->getXDR(), nullptr, &written);
         mMetaStream->flush();
+        mMetaStreamBytes.Mark(written);
     }
     if (mMetaDebugStream)
     {

diff --git a/src/ledger/LedgerManagerImpl.h b/src/ledger/LedgerManagerImpl.h
@@ -60,6 +60,7 @@ class LedgerManagerImpl : public LedgerManager
     medida::Counter& mLedgerAge;
     medida::Counter& mTransactionApplySucceeded;
     medida::Counter& mTransactionApplyFailed;
+    medida::Meter& mMetaStreamBytes;
     medida::Timer& mMetaStreamWriteTime;
     VirtualClock::time_point mLastClose;
     bool mRebuildInMemoryState{false};

diff --git a/src/util/Backtrace.cpp b/src/util/Backtrace.cpp
@@ -148,8 +148,24 @@ printCurrentBacktrace()
 }
 }
 
+#else
+
+#ifdef _WIN32
+static size_t
+backtrace(void**, size_t)
+{
+    return 0;
+}
+
+static char**
+backtrace_symbols(void** v, size_t n)
+{
+    return nullptr;
+}
+
 #else
 #include <execinfo.h>
+#endif
 
 namespace stellar
 {