-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: Add in-memory event store backed by circular buffer #361
Conversation
e89c44e
to
f7e5992
Compare
Co-authored-by: Paul Bellamy <[email protected]>
As I mentioned before, I would consider some modifications to the data structure so that we can (mostly) allocate it in advance Also, it would be good to know how much memory could be consumed by this (e.g. assuming full ledgers and certain amount of events per operation) |
I started looking into @2opremio suggestion to take advantage of the fact that there are at most 1000 operations per ledger. I used the following representation:
but the code started to be more complex and less readable because of the fact that only operations per ledger are fixed (not transactions). I'm going to file an issue to investigate improving this representation in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, but looks great otherwise.
@tsachiherman can you take another look? I just pushed a commit which addresses your latest round of feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks for the changes.
What
Add in-memory event store backed by circular buffer. This code is taken from #355 . To minimize merge conflicts, the ingestion and DB code changes will be included in a separate PR.
Why
This is necessary to complete stellar/go#4718
Known limitations
[N/A]