Upgrade crate-git-revision to 0.0.4 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Dec 5, 2022
|
The failure is in the e2e-test worker and seems unlikely to be related to this patch, but I am still trying to understand it. |
|
The failure is unrelated. This repo recently got reorganized, and there a few problems in this repo that need resolving. I'm probably going to remove those tests, we can't rely on them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade crate-git-revision to 0.0.4
Why
Keep on the same version as other soroban crates. Once fully upgraded there won't be any duplicates in the lockfiles.
I think this is the last of the stellar repos that have this crate in their manifest.
Known limitations
N/A