Updating xdr for soroban-rpc #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
soroban-rpc-xdr-update
branch
from
5de078a
to
40ce7b2
Compare
paulbellamy
force-pushed
the
soroban-rpc-xdr-update
branch
4 times, most recently
from
3c30fc9
to
203d2f1
Compare
paulbellamy
force-pushed
the
soroban-rpc-xdr-update
branch
from
203d2f1
to
bdc33d8
Compare
paulbellamy
force-pushed
the
soroban-rpc-xdr-update
branch
from
f9a8860
to
9cc598e
Compare
|
Ok, hilariously, I think the remaining e2e tests need an updated quickstart docker image to pass. Will try building quickstart locally with updates and see. Edit: Yes, I build quickstart locally, and the e2e tests pass. |
paulbellamy
force-pushed
the
soroban-rpc-xdr-update
branch
from
3c1d689
to
f3ab828
Compare
paulbellamy
requested review from
2opremio and
tsachiherman
and removed request for
2opremio
paulbellamy
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Add rpc getLedgerEntry method * fix getContractID * Fixing tests * updating rust xdr and sdk * updating to new hostfunction format * updating soroban-cli to use getLedgerEntry * rustfmt * WIP -- updating for new xdr * WIP -- updating for new xdr * Updating xdr for soroban-rpc (#279) * Updating xdr for soroban-rpc * Trying the new core version * Fix nil pointer * Need to compare contract hash not contract code now * getLedgerEntry test checks code not hash * Fixing tests * update go mod/sum to reflect the latest soroban-xdr-next branch in go monorepo * Update sdk and env to latest crates * Fix up conversions and clippy * Need to use the sandbox passphrase in the sandbox * update test mocks for new contract ids * Updating contract ids for e2e Co-authored-by: tsachiherman <[email protected]> Co-authored-by: tsachiherman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the soroban-rpc xdr, on top of get-ledger-entry branch