Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: fix that the footpoint was not set correctly when deploying the wrapped token contract #278

Merged
merged 4 commits into from
Dec 6, 2022
Merged

soroban-cli: fix that the footpoint was not set correctly when deploying the wrapped token contract #278

merged 4 commits into from
Dec 6, 2022

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Dec 1, 2022 •
edited
Loading

What

see #277
Fix that the footpoint was not set correctly when deploying the wrapped token contract.

Why

see #277

Known limitations

Lack of test cases

@overcat overcat marked this pull request as draft December 1, 2022 08:42
@overcat overcat marked this pull request as ready for review December 1, 2022 08:46
silence48
silence48 approved these changes Dec 2, 2022
View reviewed changes
Copy link

@silence48 silence48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it today, it works flawlessly now.

@leighmcculloch
Copy link
Member

I tested this and it works against the release @sreuland is preparing of the RPC, so I'm going to merge this.

For fixes like this tests would be ideal, but we're refactoring the tests in #291 as part of the release, and so I'm going to hold off on adding that right now.

@leighmcculloch leighmcculloch enabled auto-merge (squash) December 6, 2022 04:44
@leighmcculloch
Copy link
Member

Thanks @overcat !!!

@leighmcculloch leighmcculloch merged commit 2d0d37d into stellar:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@silence48 silence48 silence48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@overcat @leighmcculloch @silence48