Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: sync up with go repository #265

Merged
merged 11 commits into from
Nov 24, 2022
Merged

soroban-rpc: sync up with go repository #265

merged 11 commits into from
Nov 24, 2022

Conversation

tsachiherman
Copy link
Contributor

What

sync up with go repository.

Why

Need to sync up before removing it from the go repo.

Known limitations

N/A

go.mod Show resolved Hide resolved
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is mainly lift and move code, haven't gone through line by line, the CI tests should be passing to verify net change, looks like the rpc integration tests are having an issue in the pr workflow checks.

@tsachiherman
Copy link
Contributor Author

Yes, I'm working on addressing these; shouldn't be any material change, though.

@tsachiherman tsachiherman merged commit 89ac233 into main Nov 24, 2022
@tsachiherman tsachiherman deleted the tsachi/sync-rpc1 branch November 24, 2022 21:47
@tsachiherman tsachiherman restored the tsachi/sync-rpc1 branch May 16, 2023 16:02
@tsachiherman tsachiherman deleted the tsachi/sync-rpc1 branch June 14, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants