Inline variables in format strings #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's only complaint was format strings not embedding the variables into the string between `{}`s
leighmcculloch
approved these changes
Nov 4, 2022
leighmcculloch
changed the title
cargo +nightly clippy -- -Dclippy::pedantic happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Inline variables in format strings.
Why
Rust 1.66 introduces a lint to clippy that requires variables to be embedded in format strings.
At this moment the beta (1.66) and nightly (1.67) versions of clippy will emit warnings. This is inconvenient for people choosing to use beta and nightly. In the near future (6 weeks) we'll see this lint in stable.