Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bin name in the completion command #239

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix the bin name in the completion command #239

merged 1 commit into from
Oct 31, 2022

Conversation

fdesjardins
Copy link
Contributor

What

Change soroban-cli to soroban for the completion command

Why

Completion got broken when the bin name changed to soroban. This PR fixes that.

leighmcculloch
leighmcculloch approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 Thanks for fixing this.

@leighmcculloch leighmcculloch merged commit a515d61 into stellar:main Oct 31, 2022
@fdesjardins fdesjardins deleted the fix-completion-cmd branch October 31, 2022 21:58
@leighmcculloch leighmcculloch mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdesjardins @leighmcculloch