Add token contract e2e test #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
add-token-e2e-test
branch
from
5bf1102
to
72d031b
Compare
leighmcculloch
approved these changes
Oct 25, 2022
| @@ -66,7 +66,9 @@ jobs: | |||
| - run: make build-test-wasms | |||
| - run: docker run -d -p 8000:8000 stellar/quickstart:soroban-dev --standalone --enable-soroban-rpc --enable-core-artificially-accelerate-time-for-testing --protocol-version 20 | |||
| - run: while ! [ "$(curl -s --fail localhost:8000 | jq '.history_latest_ledger')" -gt 0 ]; do echo waiting; sleep 1; done | |||
| - run: cargo test --test 'e2e*' --target ${{ matrix.target }} -- --ignored | |||
| # Run e2e tests sequentially to avoid sequence number mismatches | |||
| # TODO: use different accounts in different tests to avoid the data race | |||
There was a problem hiding this comment.
❔ Where is the code that creates the account? I see a single key in the e2e_rpc_server.rs file but I don't see any logic that uses friendbot to create the account before the transaction is submitted.
There was a problem hiding this comment.
That logic doesn't exist, that's why I left a TODO instead of biting the bullet and doing it.
leighmcculloch
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add token creation and invocation e2e test
Why
Coverage :)
Known limitations
N/A