-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token contract e2e test #233
Conversation
5bf1102
to
72d031b
Compare
@@ -66,7 +66,9 @@ jobs: | |||
- run: make build-test-wasms | |||
- run: docker run -d -p 8000:8000 stellar/quickstart:soroban-dev --standalone --enable-soroban-rpc --enable-core-artificially-accelerate-time-for-testing --protocol-version 20 | |||
- run: while ! [ "$(curl -s --fail localhost:8000 | jq '.history_latest_ledger')" -gt 0 ]; do echo waiting; sleep 1; done | |||
- run: cargo test --test 'e2e*' --target ${{ matrix.target }} -- --ignored | |||
# Run e2e tests sequentially to avoid sequence number mismatches | |||
# TODO: use different accounts in different tests to avoid the data race |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Where is the code that creates the account? I see a single key in the e2e_rpc_server.rs
file but I don't see any logic that uses friendbot to create the account before the transaction is submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That logic doesn't exist, that's why I left a TODO instead of biting the bullet and doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question (❔), but looks good regardless.
What
Add token creation and invocation e2e test
Why
Coverage :)
Known limitations
N/A