Retroactively add binaries to the release of v0.1.2 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
force-pushed
the
release/v0.1.2
branch
2 times, most recently
from
418e5e2
to
9f0de50
Compare
leighmcculloch
force-pushed
the
release/v0.1.2
branch
from
cc47bd3
to
70110a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Retroactively add binaries to the release of v0.1.2.
Why
For installs without building from source.
The main reason to add this is so that we can install soroban-cli into places that are inconvenient to do a build from source. For example, when installing soroban-cli into a repl.it, the build consumes so much disk space that it often fails to install.
I've added this process to the existing publish action because I think it will be beneficial if we lead into using this same process for any Rust project that has binaries. There might be some growing pains with that, if for example we have tools we only want to release on specific architectures, etc. I think we can tackle those problems when they arise rather than try to presolve for them.
I'm not making a new release just to get binaries because it would be helpful if the binaries we release for use in things like repl.it match the release everyone else is already using.