Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the git revision logic to a crate #224

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Move the git revision logic to a crate #224

merged 1 commit into from
Oct 20, 2022

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 19, 2022 •
edited
Loading

What

Move the git revision logic to a crate:
https://crates.io/crates/crate-git-revision

Why

So that the logic can be applied to other repositories.

@leighmcculloch leighmcculloch marked this pull request as ready for review October 19, 2022 23:42
graydon
graydon approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leighmcculloch leighmcculloch merged commit 125e251 into main Oct 20, 2022
@leighmcculloch leighmcculloch deleted the use-crate-git-revision branch October 20, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @graydon