Check container is ready in e2e-test ci job #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Oct 19, 2022
2opremio
reviewed
Oct 19, 2022
| - run: docker run -d -p 8000:8000 stellar/quickstart:soroban-dev --standalone --enable-soroban-rpc --enable-core-artificially-accelerate-time-for-testing --protocol-version 20 && sleep 15 | ||
| - run: while ! [ "$(curl -s --fail localhost:8000 | jq '.history_latest_ledger')" -gt 0 ]; do echo waiting; sleep 1; done |
There was a problem hiding this comment.
you may want to merge this with the prior command
There was a problem hiding this comment.
I'd rather keep it separate so that it is clear in the GitHub Action when the container has started vs the build is waiting for the container to be ready. That seemed to work well here:
https://github.com/stellar/starlight/blob/919096552e44eec5ec3fd6278922396926239874/.github/workflows/sdk.yml#L59-L62
What do we get out of merging it?
There was a problem hiding this comment.
No strong opinions, I think it's easier to read if done in the same step (spawn the docker container and make sure it's working).
Co-authored-by: Alfonso Acosta <[email protected]>
2opremio
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Check container is ready in e2e-test ci job by checking if the history ledgers is greater than 0.
Why
I noticed a TODO in here when working in the same file. We did this in the starlight project by adding a simple curl and check on the number of history ledgers ingested. Not sure if that is sufficient here, but I think it might be sufficient.