Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contractCode to token init footprint #201

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Add contractCode to token init footprint #201

merged 3 commits into from
Oct 7, 2022

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Oct 7, 2022 •
edited
Loading

What

  • Add the contractCode ledger entry to the token init op footprint.
  • Fix type of the Admin & Metadata footprint entries

Why

Note

I fixed this by getting the TxEnvelope from horizon, and running simulateTransaction with it. Then used laboratory to compare the submitted footprint with the simulated one.

@leighmcculloch leighmcculloch merged commit ff47b5b into main Oct 7, 2022
@leighmcculloch leighmcculloch deleted the token-create-footprint branch October 7, 2022 08:59
@leighmcculloch leighmcculloch mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the CLI to create token
2 participants
@paulbellamy @leighmcculloch