Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename private key to secret key #171

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Rename private key to secret key #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5358d5a
Rename private key to secret key
leighmcculloch Sep 30, 2022
288a72b
rename env so it has a prefix
leighmcculloch Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/deploy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ pub struct Cmd {
long,
required_unless_present = "contract-id",
conflicts_with = "contract-id",
requires = "private-strkey",
requires = "secret-key",
requires = "network-passphrase"
)]
rpc_server_url: Option<String>,
/// Private key to sign the transaction sent to the rpc server
#[clap(long = "private-strkey", env)]
private_strkey: Option<String>,
/// Secret 'S' key used to sign the transaction sent to the rpc server
#[clap(long = "secret-key", env = "SOROBAN_SECRET_KEY")]
secret_key: Option<String>,
/// Network passphrase to sign the transaction sent to the rpc server
#[clap(long = "network-passphrase")]
network_passphrase: Option<String>,
Expand Down Expand Up @@ -139,7 +139,7 @@ impl Cmd {

async fn run_against_rpc_server(&self, contract: Vec<u8>) -> Result<(), Error> {
let client = Client::new(self.rpc_server_url.as_ref().unwrap());
let key = utils::parse_private_key(self.private_strkey.as_ref().unwrap())
let key = utils::parse_private_key(self.secret_key.as_ref().unwrap())
.map_err(|_| Error::CannotParsePrivateKey)?;

// Get the account sequence number
Expand Down