Extract soroban_rpc crate #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
force-pushed
the
refac
branch
from
428ed86
to
52462ae
Compare
paulbellamy
approved these changes
Sep 30, 2022
src/rpc/mod.rs
Outdated
| // TODO: add results | ||
| } | ||
|
|
||
| pub struct Rpc { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extract soroban_rpc crate
Why
To tidy up the deploy code. This code was written by @paulbellamy and I'm just extracting it from his Pr in progress into a separate Pr so that we can land it sooner: #166.
Thanks @paulbellamy!!!