Update deploy subcommand to use create_contract_from_source()
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update deploy subcommand so that when it's used against an RPC server uses
create_contract_from_source()instead ofcreate_contract_from_ed25519()Also, print the contract ID once created.
I used this CPP test as a reference: https://github.com/stellar/stellar-core/blob/2dccaae1ec9db8e82580bc5e7b84d404d1836f3c/src/transactions/test/InvokeHostFunctionTests.cpp#L135
Why
#152
Known limitations
I haven't really been able to test this end-to-end against an RPC server because
soroban-cli servestill only seems to supportHostFunction::InvokeContract