feat: allow source account to be a public key #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this would fail if not `--build-only` since we rely on source account being a reference to a private key or seed. However, this is will be useful for `--sign-with-lab` which users will likely copy their public keys from their wallet to use on the CLI.
leighmcculloch
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow public keys to be used with
--source.Why
This is will be useful for
--sign-with-labwhich users will likely copy their public keys from their wallet to use on the CLI. It will also be useful when we expand--sign-with-*more generally allowing a different key than the source account to sign the transaction.Known limitations
Currently this would fail if not
--build-onlysince we rely on source account being a reference to a private key or seed