-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contract alias ls
.
#1572
Add contract alias ls
.
#1572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one thought is that it would be good to have a way to list all across all networks. Like -l on other list commands.
@willemneal I think that's a good idea (#1420 even mentions it), but I wonder how we can achieve that by using I tried to make it work, but failed to make everything work. |
As an idea we can add list |
@Ifropc I did that, but network options are required, and simply using |
Yeah, I was looking into groups, unfortunately we can't make it work easily while using derive API, this is a known issue in clap (and I don't think it will be changed, based on the discussion in Clap repo). So our only option is to migrate to builder for networks and maybe other flags as well, which we probably don't want to spend our time on right now. |
I guess we should ignore |
I think we can keep this command simpler and output all aliases for all networks, and provide no filtering options. |
@leighmcculloch works for me! |
The list output is currently this: $ cargo run contract alias ls --global
Compiling soroban-cli v21.4.1 (/Users/fnando/Projects/stellar/stellar-cli/cmd/soroban-cli)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.08s
Running `target/debug/soroban contract alias list --global`
ℹ️ Aliases available for network 'Test SDF Network ; September 2015'
hello_world: CAXUMKGXAOY6IAO36XJV6DSOQBMBANSUJ6NR5EXIF27ZWNPW7OOTTHPC
increment: CALLOOCCCJRZ6AZAJSKNCTDZ766N4ANVRKRJPHC65KDV7RJCS37PS4XY
ℹ️ Aliases available for network 'Standalone Network ; February 2017'
hello_world: CC47LWR7ZJH2QQTFUUNRERMBPBAUHIVLKHIKACV6VVZEEQJIHJOJNGPL
$ echo $?
0
$ cargo run contract alias ls
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s
Running `target/debug/soroban contract alias list`
⚠️ No aliases defined for network
$ echo $?
1 |
edfe970
to
4e4bc49
Compare
c1d29de
to
05c5136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What
Why
#1420
Known limitations
N/A