Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move container output to the rich print system. #1533

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Move container output to the rich print system. #1533

merged 3 commits into from
Aug 13, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Aug 8, 2024

What

$ stellar network container start testnet
ℹ️ Starting testnet network
✅ Started container
🔎 You can see logs by running `stellar network container logs testnet`
ℹ️ To stop this container, use `stellar network container stop testnet`

$ stellar network container stop testnet
ℹ️ Stopping testnet container
✅ Container has been stopped

Why

So we only have one way of printing rich output everywhere.

Known limitations

N/A

leighmcculloch
leighmcculloch approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple text suggestions otherwise lgtm

cmd/soroban-cli/src/commands/network/container/start.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/commands/network/container/start.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/commands/network/container/stop.rs Outdated Show resolved Hide resolved
elizabethengelman
elizabethengelman approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 👏

@leighmcculloch leighmcculloch enabled auto-merge (squash) August 13, 2024 20:45
@leighmcculloch leighmcculloch merged commit 368f666 into main Aug 13, 2024
25 checks passed
@leighmcculloch leighmcculloch deleted the output-container branch August 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@elizabethengelman elizabethengelman elizabethengelman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnando @leighmcculloch @elizabethengelman