Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short name, so it doesn't conflict with the verbose short name. #1525

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Aug 6, 2024

What

Remove short flag due to a conflict introduced by #1510.

Why

$ stellar network container start
thread 'main' panicked at /Users/fnando/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.8/src/builder/debug_asserts.rs:112:17:
Command start: Short option names must be unique for each argument, but '-v' is in use by both 'protocol_version' and 'verbose'
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Known limitations

N/A

This conflict was introduced by the move to global switches on pr #1510.
@fnando fnando enabled auto-merge (squash) August 6, 2024 19:37
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs help updated otherwise lgtm.

@fnando fnando merged commit 38aa361 into main Aug 6, 2024
24 of 26 checks passed
@fnando fnando deleted the short-name-conflict branch August 6, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants