build: update system-test quickstart & stellar-sdk #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current system-test run is using very outdated versions of the quickstart Docker image and @stellar/stellar-sdk
willemneal
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
system-testCI workflow's versions of Quickstart image andstellar-sdk NPM module.
Why
They're real out of date! The version of Quickstart hasn't been updated
for three months, and the version of stellar-sdk is a major version
behind and doesn't have helpful functionality like the contract client.
This will help me fix #1500 in a way that doesn't break every other branch.
Known limitations
[TODO or N/A]