Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error if friendbot says account already funded #1508

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jul 31, 2024

What

Do not error if friendbot says account already funded.

Why

If friendbot indicated that the account is already fully funded to the starting balance, because the user's goal is to get funded, and the account is funded so it is success much the same.

Close #1389 (comment)

@leighmcculloch leighmcculloch marked this pull request as ready for review July 31, 2024 01:46
@leighmcculloch leighmcculloch enabled auto-merge (squash) July 31, 2024 02:36
@leighmcculloch leighmcculloch merged commit 708336c into main Jul 31, 2024
25 checks passed
@leighmcculloch leighmcculloch deleted the fundnoerror branch July 31, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

keys fund: top-off accounts if below --minimum-balance
2 participants