change fund to top off if balance below 10k xlm

[BlaineHeffron]

What

When using stellar network fund it will now top off the balance if the account exists and has a balance lower than 10k XLM.

Why

This makes fund more useful because now one doesn't need to create a temporary account and transfer funds from that temporary account in order to add funds. Before, fund only created an account that didn't exist and added funds to it. See #1389

Known limitations

N/A

[willemneal]

Yay easy top ups!

[leighmcculloch]

I'd like to roll this change back and move ahead with making this change in friendbot. See my comments on the original issue here:

• keys fund: top-off accounts if below --minimum-balance #1389 (comment)

[BlaineHeffron]

Sounds good to me, friendbot is definitely the way to go about it. Perhaps once that is merged into a release we can roll this change back? I do need it for this issue which I will be working on soon: #1380

[willemneal]

@leighmcculloch Our original thoughts were this was a stop gap measure while it was added to friendbot. That is the definitely the proper solution.

[leighmcculloch]

Friendbot has been updated with the following change and that change is rolled out:

• stellar/go@31fc8f4

So we should be good to roll this back now. Note that the errors friendbot changed slightly, instead of the created error, it returns the following if the account is already funded at or above the starting balance of 10k:

{
  "type": "https://stellar.org/horizon-errors/bad_request",
  "title": "Bad Request",
  "status": 400,
  "detail": "account already funded to starting balance"
}

[leighmcculloch]

I opened this revert, but I'll hold it until @BlaineHeffron or @willemneal if you can confirm if a complete revert is okay or if any of the change needs keeping. Thanks!

• Revert "change fund to top off if balance below 10k xlm" #1487