Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: add basic versions of getHealth and getAccount #134

Merged
merged 4 commits into from
Sep 19, 2022
Merged

CLI: add basic versions of getHealth and getAccount #134

merged 4 commits into from
Sep 19, 2022

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Sep 16, 2022 •
edited
Loading

What

Add basic versions of getHealth and getAccount methods to cli serve

Why

It's the last two methods cli serve was missing from the meridian milestone methods.

Known limitations

  • Account sequence is never incremented nor checked for now.
  • Account doesn't include balances yet.

Added issue #133 to address both of those later.

@paulbellamy paulbellamy mentioned this pull request Sep 16, 2022
Open
@paulbellamy paulbellamy merged commit d2d5383 into main Sep 19, 2022
@paulbellamy paulbellamy deleted the gethealth branch September 19, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @leighmcculloch