Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "soroban-rpc: update go package dependencies" #1044

Closed
wants to merge 1 commit into from

Conversation

2opremio
Copy link
Contributor

Reverts #1030

It enforces using Go 1.21 to compile soroban-tools

@2opremio 2opremio requested a review from tsachiherman October 23, 2023 13:49
@2opremio
Copy link
Contributor Author

2opremio commented Oct 23, 2023

For some reason go mod tidy tries to install [email protected] even if I downgrade jrpc2 to jrpc2 to v1.1.0

% go mod tidy -go=1.20   
go: finding module for package github.com/google/shlex
go: found github.com/google/shlex in github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
go: github.com/creachadair/[email protected] requires [email protected], but 1.20 is requested

@willemneal
Copy link
Member

Why not upgrade to the 1.21?

@2opremio
Copy link
Contributor Author

2opremio commented Oct 23, 2023

Because we want to support the last 2 go releases (at least in stellar/go)

@2opremio
Copy link
Contributor Author

2opremio commented Oct 23, 2023

OK, it seems the problem is stellar/go is also broken :(

alfonsoacosta@macbookM2Max soroban-tools % go mod graph | grep mds
github.com/stellar/soroban-tools github.com/creachadair/[email protected]
github.com/creachadair/[email protected] github.com/creachadair/[email protected]
github.com/creachadair/[email protected] github.com/google/[email protected]
github.com/creachadair/[email protected] [email protected]
github.com/stellar/[email protected] github.com/creachadair/[email protected]

@2opremio
Copy link
Contributor Author

See stellar/go#5088 . We should do the same in soroban-rpc next

@2opremio 2opremio closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants