Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban contract bindings typescript nesting when running > once #752

Closed
kalepail opened this issue Jul 6, 2023 · 0 comments · Fixed by #849
Closed

soroban contract bindings typescript nesting when running > once #752

kalepail opened this issue Jul 6, 2023 · 0 comments · Fixed by #849
Labels
bug Something isn't working

Comments

@kalepail
Copy link
Contributor

kalepail commented Jul 6, 2023

When running soroban contract bindings typescript more than 1 time the deployed package nests into the existing project.

Yay
Screenshot 2023-07-06 at 3 51 19 PM

Ew
Screenshot 2023-07-06 at 3 51 51 PM
@kalepail kalepail added the bug Something isn't working label Jul 6, 2023
@kalepail kalepail mentioned this issue Jul 6, 2023
Merged
chadoh added a commit to AhaLabs/stellar-cli that referenced this issue Aug 9, 2023
@chadoh
feat(bindings-ts)!: rm --contract-name, add --overwrite
d8e7ea1 
Fixes stellar#752

Removes the `--contract-name` argument from `bindings typescript`, since
this was often confused with `--output-dir` and, really, just using the
file path from the end of `--output-dir` is sufficient.

Adds `--overwrite`. If you specify an `--output-dir` that already
exists, by default it will not be overwritten. Instead, a descriptive error
will be thrown, letting you know that you can add `--overwrite` to
overwrite the directory.

Previously, if you specified an `--output-dir` that already existed, it
would create a new directory with the same name inside this directory,
which can lead to confusing bugs.
@chadoh chadoh mentioned this issue Aug 9, 2023
Merged
chadoh added a commit to AhaLabs/stellar-cli that referenced this issue Aug 9, 2023
@chadoh
feat(bindings-ts)!: rm --contract-name, add --overwrite
fb903a9 
Fixes stellar#752

Removes the `--contract-name` argument from `bindings typescript`, since
this was often confused with `--output-dir` and, really, just using the
file path from the end of `--output-dir` is sufficient.

Adds `--overwrite`. If you specify an `--output-dir` that already
exists, by default it will not be overwritten. Instead, a descriptive error
will be thrown, letting you know that you can add `--overwrite` to
overwrite the directory.

Previously, if you specified an `--output-dir` that already existed, it
would create a new directory with the same name inside this directory,
which can lead to confusing bugs.
tsachiherman added a commit that referenced this issue Aug 10, 2023
@chadoh @tsachiherman
feat(bindings-ts)!: rm --contract-name, add --overwrite (#849)
e2c1b97 
Fixes #752

Removes the `--contract-name` argument from `bindings typescript`, since
this was often confused with `--output-dir` and, really, just using the
file path from the end of `--output-dir` is sufficient.

Adds `--overwrite`. If you specify an `--output-dir` that already
exists, by default it will not be overwritten. Instead, a descriptive error
will be thrown, letting you know that you can add `--overwrite` to
overwrite the directory.

Previously, if you specified an `--output-dir` that already existed, it
would create a new directory with the same name inside this directory,
which can lead to confusing bugs.

Co-authored-by: Tsachi Herman <[email protected]>
kalepail pushed a commit to kalepail/soroban-tools that referenced this issue Aug 10, 2023
@chadoh @tsachiherman @kalepail
feat(bindings-ts)!: rm --contract-name, add --overwrite (stellar#849)
a650d03 
Fixes stellar#752

Removes the `--contract-name` argument from `bindings typescript`, since
this was often confused with `--output-dir` and, really, just using the
file path from the end of `--output-dir` is sufficient.

Adds `--overwrite`. If you specify an `--output-dir` that already
exists, by default it will not be overwritten. Instead, a descriptive error
will be thrown, letting you know that you can add `--overwrite` to
overwrite the directory.

Previously, if you specified an `--output-dir` that already existed, it
would create a new directory with the same name inside this directory,
which can lead to confusing bugs.

Co-authored-by: Tsachi Herman <[email protected]>
willemneal pushed a commit to AhaLabs/stellar-cli that referenced this issue Aug 10, 2023
@chadoh @tsachiherman @willemneal
feat(bindings-ts)!: rm --contract-name, add --overwrite (stellar#849)
0757fb2 
Fixes stellar#752

Removes the `--contract-name` argument from `bindings typescript`, since
this was often confused with `--output-dir` and, really, just using the
file path from the end of `--output-dir` is sufficient.

Adds `--overwrite`. If you specify an `--output-dir` that already
exists, by default it will not be overwritten. Instead, a descriptive error
will be thrown, letting you know that you can add `--overwrite` to
overwrite the directory.

Previously, if you specified an `--output-dir` that already existed, it
would create a new directory with the same name inside this directory,
which can lead to confusing bugs.

Co-authored-by: Tsachi Herman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bindings-ts)!: rm --contract-name, add --overwrite AhaLabs/stellar-cli
1 participant
@kalepail