Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate core XDR change impact for adding ContractCostType::ChaCha20DrawBytes #1000

Closed
anupsdf opened this issue Oct 4, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@anupsdf
Copy link

anupsdf commented Oct 4, 2023

What?

Evaluate the impact of Core XDR ContractCostType::ChaCha20DrawBytes changes in stellar/stellar-xdr@f2f213c

@anupsdf anupsdf added the bug Something isn't working label Oct 4, 2023
@anupsdf anupsdf added this to the Soroban Pubnet Release milestone Oct 4, 2023
@anupsdf anupsdf changed the title Evaluate core XDR change impact ContractCostType::ChaCha20DrawBytes Evaluate core XDR change impact for adding ContractCostType::ChaCha20DrawBytes Oct 4, 2023
@tamirms
Copy link
Contributor

tamirms commented Oct 4, 2023

I don't think we need to do anything specifically for this change or #1001 because we do not construct ContractCostType xdr values in either horizon or soroban-rpc. I think the only work required is updating the xdr definitions in the go monorepo and then bumping the go monorepo dependency in soroban-rpc.

I think the work for updating the xdr definitions can be pointed as a 3 (stellar/go#4788 is a similar issue from the past which can be used as a reference point).

@mollykarcher
Copy link
Contributor

Closing in favor of stellar/go#5075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants