Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Update XDR to support network confirm transaction type #4788

Closed
tsachiherman opened this issue Mar 6, 2023 · 4 comments
Closed

xdr: Update XDR to support network confirm transaction type #4788

tsachiherman opened this issue Mar 6, 2023 · 4 comments
Assignees

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023

What

Update XDR to support network confirm transaction type.

There will be a new transaction type NetworkConfirm (todo: confirm this name). We should ingest/store/etc this like any other transaction.

Epic

stellar/stellar-cli#519

@2opremio
Copy link
Contributor

@tsachiherman I have bumped the XDR definitions at #4851 but I don't see any NetworkConfirm transaction type. I will ask on Slack

@sisuresh
Copy link

@tsachiherman Is this issue about consuming changes to network settings? If so, there's no new operation or transaction type. There's a new ledger entry type (CONFIG_SETTING), and you can consume the changes for it through tx meta.

@tsachiherman
Copy link
Contributor Author

@tsachiherman Is this issue about consuming changes to network settings? If so, there's no new operation or transaction type. There's a new ledger entry type (CONFIG_SETTING), and you can consume the changes for it through tx meta.

I see. @2opremio do we need to update the ingestion to ignore this ledger entry type ?

@2opremio
Copy link
Contributor

2opremio commented Apr 20, 2023

I think the new entry is already being considered for ingestion in Horizon (probably just ignored). @tamirms @Shaptic do you remember?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants