Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't rm target when cleaning #124

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 14, 2023

The clean command was improved in #122, but it may have been made somewhat too aggressive.

I often symlink my local soroban build into target/bin/soroban. If I forget to remove target from clean, then this quickly gets deleted, which leads to unexpected behavior.

So I've been running reset over and over with target removed from the list of clean targets, and I haven't noticed any problems.

@chadoh
Copy link
Contributor Author

chadoh commented Jul 14, 2023

@tyvdh what do you think?

@kalepail
Copy link
Contributor

Fine with me if the CI build passes

@chadoh
Copy link
Contributor Author

chadoh commented Jul 17, 2023

@tyvdh do you have the ability to merge? I do not.

@kalepail kalepail merged commit 5c21ade into stellar:main Jul 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants