Value and object representation overhaul #879

graydon · 2023-03-02T20:59:05Z

This is the SDK adaptation of stellar/rs-soroban-env#682, which we're going to try writing collaboratively

The todos should be converted to proper types when we add the support of the respective types.

This should probably be a temporary limitation; we now may be able to allow longer names/symbols.

- Allow using Symbol::from_small_str for str literals (still not sure how that should look like in the final version) - Update a couple too long token-spec function names to 9 symbols (not committing this as we should increase the limit instead)

…port

…per type

Also refactor the `symbol!` uses to use `Symbol::short` in most places (the tests still don't build though, so there might be places where I've missed something).

Also contains some minor fixes.

With --no-default-features long symbols are logged just as #obj currently, which isn't testable.

…tation has changed.

…e an env (Symbol)

jayz22 · 2023-03-08T20:48:44Z

Accidentally approved.

### What [TODO: Short statement about what is changing.] ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A]

Bump XDR

6602674

graydon requested review from dmkozh, sisuresh and jayz22 and removed request for dmkozh March 2, 2023 20:59

dmkozh and others added 24 commits March 2, 2023 18:53

Fixed some macros and added todo! stubs for the spec.

19d934a

The todos should be converted to proper types when we add the support of the respective types.

Use small str for symbols in enums/structs.

3dcfb88

This should probably be a temporary limitation; we now may be able to allow longer names/symbols.

Update Address and Bytes SDK types.

80a66b5

Return some accidentally removed functions

6b6881c

Update map.rs to xdr.rs

3145bb7

SDK builds with a couple of hacks:

ded7bab

- Allow using Symbol::from_small_str for str literals (still not sure how that should look like in the final version) - Update a couple too long token-spec function names to 9 symbols (not committing this as we should increase the limit instead)

Implement new EnvBase methods.

d196c20

Fix SDK build for wasm-target build

8717dfd

Use new env helpers to smuggle known-ok small symbol body through macro.

28b01f3

Update derive_{client,fn}.rs for long symbols

e072727

Update derive_enum to long-symbol / string-array support

8227e0a

Update derive_{struct,tuple_struct} to long-symbol / string-array sup…

7c13835

…port

Fix missing import in derive_fn

0dd5bc2

Revert some changes to macros in anticipation of SDK-side Symbol wrap…

868ba3d

…per type

Add SDK Symbol type.

8158a61

Also refactor the `symbol!` uses to use `Symbol::short` in most places (the tests still don't build though, so there might be places where I've missed something).

Mop up some errors and typos in macro code

c6fbb1a

Fix a couple tests (at least if/until we decide they should not panic)

da510d9

Add some docs for Symbol.

7034270

Update symbol char limit

58b945a

Allow using longer field names in structs.

38348ad

Fix sign test.

7c4d3f4

Update go snippet for signature verification

437ce29

Sort UDT fields by key

8502631

Add proper compile errors for function and enum variant names.

3d01e00

Also contains some minor fixes.

dmkozh added 2 commits March 8, 2023 13:07

Update contract hashes and remove long symbol from test.

29a0927

With --no-default-features long symbols are logged just as #obj currently, which isn't testable.

Update the UDT encoding test - it's expected that the binary represen…

dbd1f98

…tation has changed.

This was referenced Mar 8, 2023

Value and object representation overhaul stellar/rs-soroban-env#682

Merged

Value representation overhaul stellar/stellar-xdr#70

Merged

Translate Void to () in spec.

45e9cb5

graydon mentioned this pull request Mar 8, 2023

Value representation overhaul stellar/rs-soroban-env#679

Closed

graydon added 2 commits March 8, 2023 12:30

Use wasm-optimized MaybeEnv for cases where we might or might-not hav…

f342a4e

…e an env (Symbol)

Fix a couple missing clones in wasm-gated variants

6f61dd5

jayz22 approved these changes Mar 8, 2023

View reviewed changes

Add boiler plate for Timepoint, Duration, U/I256 (#880)

82312df

### What [TODO: Short statement about what is changing.] ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A]

sisuresh approved these changes Mar 8, 2023

View reviewed changes

graydon and others added 3 commits March 8, 2023 16:11

Bump refs to recent env and xdr changes, unpatch

d1c9d65

Add String wrapper type (#882)

8ec4183

### What [TODO: Short statement about what is changing.] ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A]

Fix doc tests

0dda29b

graydon merged commit 754c43b into main Mar 9, 2023

graydon deleted the midwinter-val-reform branch March 9, 2023 01:43

leighmcculloch mentioned this pull request Apr 27, 2023

Bring back symbol! #927

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Value and object representation overhaul #879

Value and object representation overhaul #879

graydon commented Mar 2, 2023

jayz22 commented Mar 8, 2023

Value and object representation overhaul #879

Value and object representation overhaul #879

Conversation

graydon commented Mar 2, 2023

jayz22 commented Mar 8, 2023