Move ScVal<>RawVal conversion to common #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, I got pretty lost doing this and turns out I don't need it. But maybe it is still useful for some other reason to get the RawVal <> ScVal conversion outside the Host? Thoughts @graydon? |
|
I think I'm ok with this .. need to study in a little more detail tomorrow, too wiped out tonight. |
leighmcculloch
commented
Jul 21, 2022
| } else if tag_static.is_type(ScStatic::LedgerKeyContractCodeWasm) { | ||
| Ok(ScVal::Static(ScStatic::LedgerKeyContractCodeWasm)) | ||
| } else { | ||
| Err(ConversionError) |
There was a problem hiding this comment.
Unfortunately because these conversion can be used outside the host they can no longer return nice meaningful host errors. I don't see a way around this, so I'm going to press ahead with this, and maybe we can improve it somehow. Lmk if you see a way.
cc @graydon
There was a problem hiding this comment.
I put a lot of machinery for richer errors in EnvBase over in #243, maybe it's usable here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move ScVal<>RawVal conversion out of the host and into common.
Why
The host does not need to own conversion between these types as conversion between these types is mostly independent of the host. The host does need to be able to map objects into object handles though and the Host can provide an implementation of the trait for doing that.
While I was working on the CLI I need to be able to convert between these values, and so I at least need to make public the functions for doing the conversions. Moving them out into common felt natural.
Close #106
Known limitations
N/A