-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured debug events #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structurally seems ok, a handful of implementation nits (especially the back-and-forth between XDR and host domain objects/values).
@sisuresh resolved most conversations, thanks! a few tiny nits remain but none are blocking, I'll set review-approved and you can merge whenever based on your preference re: fixing them or just moving on :) |
(I believe you can push the "resolve" button on those remaining conversations, if I understand GH policy correctly) |
Refactor of #640.
Add diagnostic ContractEvents that are not metered. I used ContractEvents because they are structured, allowing downstream consumers to parse a format they should already be familiar with if they consume regular events. These are not the same as the existing DebugEvents, which are non structured messages returned by the host. These diagnostic events are also returned by the host, but should be included in a non hashed portion of tx meta.
The associated core and xdr changes would look something like sisuresh/stellar-core@78d67fd and sisuresh/stellar-xdr-next@878cc77.
Note that -
InternalEventsBuffer::record
needs metering added for non structured debug events.