Adapt Storage and SnapshotSource to use Rc only.
#700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Feb 22, 2023
Thanks @dmkozh. I just want to go through the whole stack: core, sdk, rpc to make sure there are no major disruptions there if this lands. Once that's done, I'll mark this ready for review. |
This was referenced Feb 23, 2023
|
The churn on the downstream (core, sdk, rpc) seems pretty minimal (see the three draft PRs mentioned above), so I'm marking this ready for review. |
jayz22
force-pushed
the
storage-interface
branch
from
751ff58 to
1bd2cac
Compare
graydon
requested changes
Feb 24, 2023
|
@graydon I've addressed all your feedback around changing
|
This was referenced Feb 24, 2023
graydon
approved these changes
Feb 24, 2023
dmkozh
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Feb 27, 2023
### What Adapt to env changes in stellar/rs-soroban-env#700 ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #603.
This PR explores the 2nd solution described in the issue above. By adapting the
StorageandSnapshotSourceto usingRc, it eliminates the unnecessary cloning ofLedgerKeyandLedgerEntry.Why
The
LedgerKeyandLedgerEntryare deep structures (containsScVal). Cloning them can be very expensive. Also in order to properly charge the cloning to the budget.MeteredCloneneeds to be implemented for them and all their substructures, which adds bloating to the code.Known limitations
[TODO or N/A]