-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single balances in the Stellar Asset Contract #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Dec 16, 2022
sisuresh
commented
Dec 16, 2022
dmkozh
reviewed
Dec 16, 2022
jayz22
reviewed
Dec 19, 2022
dmkozh
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates how balances are stored for Stellar accounts. Stellar account balances must be stored in classic trustlines, and classic trustlines semantics are followed. For example-
This PR also makes a minor improvement related to burn(clawback) - it can be called by the admin even if the balance/trustline is frozen/deauthorized.
Improvements I'll work on while this PR is being reviewed
Identifier
-like struct that doesn't includeAccount
for safety.Next PR will update the interface
The follow up to this will be a changes that updates to interface to make the terminology match more closely with classic, and will resolve some inconsistencies in this PR like -