Pure wasmi 036 #1442
Merged
Pure wasmi 036 #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
reviewed
Aug 8, 2024
graydon
force-pushed
the
pure-wasmi-036
branch
from
b01e798 to
7149b92
Compare
dmkozh
approved these changes
Aug 14, 2024
graydon
force-pushed
the
pure-wasmi-036
branch
from
a8ddd29 to
aecb76a
Compare
graydon
force-pushed
the
pure-wasmi-036
branch
from
aecb76a to
be16022
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler alternative to #1434 -- though it cribs some code from there -- focused on the cruder strategy of "just ship two sorobans in core", with soroban 22 not being able to replay soroban 21 contracts precisely, but soroban 21 being linked-in to core to handle such replay.
This makes the task here dramatically simpler -- just adapt to API changes in wasmi and recalibrate -- with a certain amount more work to do on the core side, but not a ton.