-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fn to find out if Host can be finished #1182
Conversation
I'm not necessarily opposed to this change, but I wonder if it's needed for your purpose. You can get read-only access to storage and events at any point - there is really no need to destruct host to do that (and IIUC the linked PR doesn't actually call |
The SDK needs to know if the I could add a |
I see, thanks for the explanation. |
### What Autosave a test snapshot file on every test exit. ### Why To encourage the over-time consistency testing of contracts. To provide a mechanism where any developer who commits the generated files can see changes in observable behavior that arises unexpectedly over time. Close #1082 ### Merging To be merged to `main` after: - [x] Adding events to the `Snapshot`. - [ ] ~Adding budget to the `Snapshot`. _(Maybe, seems less clear if should be included.)_~ - [x] Support multiple Envs in a single test writing multiple files. - [x] #1142 - [x] stellar/rs-soroban-env#1182 - [x] #1135
What
Add fn to find out if Host can be finished.
Why
So that the SDK can ask the Host if it has no more references left and it is able to be finished without calling try_finish which is destructive.
I plan to use this in: