Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code review and cleanup of host.rs module #1088

Merged
merged 11 commits into from
Oct 11, 2023
Merged

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Sep 27, 2023

Today I didn't get as much done -- had some errands and a doctor appointment -- but my goal was to get through the residual bits of host.rs and I did that at least. Along the way I removed the allows that enabled un-warned dead code and unused variables, and found some stuff:

  • Two missing error checks on linear-memory "unpack" vector lengths. These don't represent a major vulnerability, but they do allow users to do an unpack to a mismatched vector length, which could hide a bug. A footgun at least. Fixed.
  • A dead cost type, based on a previous iteration of the secp256k1 interface. Filed ComputeEcdsaSecp256k1Key is never used #1087 to track removing it.
  • Some diagnositcs weren't using the names we so meticulously pass down to them. Just throwing them out. Fixed.
  • There was a bunch of dead code and over-public interfaces. Fixed.

@graydon graydon requested review from sisuresh and a team as code owners September 27, 2023 08:02
@graydon graydon requested a review from dmkozh September 27, 2023 08:02
@graydon graydon force-pushed the graydon-code-review-6 branch from 6e4b1b0 to f05e7d9 Compare September 27, 2023 08:04
@graydon graydon force-pushed the graydon-code-review-6 branch from 7b1d7ba to 2c45346 Compare October 10, 2023 22:32
@graydon graydon enabled auto-merge October 10, 2023 22:32
@graydon graydon force-pushed the graydon-code-review-6 branch from 2c45346 to c3ef779 Compare October 10, 2023 22:44
@graydon graydon added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 7e90b1b Oct 11, 2023
@graydon graydon deleted the graydon-code-review-6 branch October 11, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants