Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor host to support the new expiration ledger approach. #1015

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Aug 23, 2023

What

Refactor host to support the new expiration ledger approach.

  • Pass expiration ledgers as side input to the ledger entries
  • Adapt to new XDR (removal of expiration_ledger_seq and expiration extensions)
  • Get rid of the autobump support.

Why

Supporting the new way for specifying entry expiration

Known limitations

N/A

@anupsdf anupsdf added blocking-sdk An issue that is blocking progress on the SDK and removed blocking-sdk An issue that is blocking progress on the SDK labels Aug 23, 2023
@dmkozh dmkozh force-pushed the expiration_refactor branch from ed73037 to 73084f9 Compare August 24, 2023 16:33
@dmkozh dmkozh requested a review from a team as a code owner August 24, 2023 16:33
@dmkozh dmkozh force-pushed the expiration_refactor branch from 73084f9 to eb1c638 Compare August 24, 2023 16:38
- Pass expiration ledgers as side input to the ledger entries (temporarily set `expiration_ledger_seq` to 0 until it's removed from XDR)
- Get rid of the autobump support.
@dmkozh dmkozh force-pushed the expiration_refactor branch from eb1c638 to fc02733 Compare August 24, 2023 17:05
@dmkozh dmkozh removed their assignment Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants