Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to reduce burden of "patch" dependency use on upstream crates #567

Closed
leighmcculloch opened this issue Nov 9, 2022 · 0 comments · Fixed by #568, stellar/rs-soroban-sdk#762 or stellar/stellar-cli#252
Assignees

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Nov 9, 2022

@tsachiherman highlighted recently how the use of [patch.*] in this repo is a burden to crates upstream in the dependency graph.

During development we use the [patch.*] configuration in Cargo to override the version dependencies for each full repo. This has a side effect that every repo has to know about its dependencies transitive dependencies that also require the patch entries.

There are other ways we can express these development/unreleased dependencies. Specifically we can move the git references onto the dependency definitions itself, making them automatically carry to importers, and we can do so at the repo level by using Rust 1.64's workspace inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment